Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortran indexing broken #4689

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fortran indexing broken #4689

wants to merge 2 commits into from

Conversation

navinp0304
Copy link
Contributor

As of now fortran indexing is broken because of my previous change.

 Second argument of substring is wrong in my previous commit 

It should be 
cmatch.substring(cmatch.length() - 1, cmatch.length()) instead of  cmatch.substring(cmatch.length() - 1, 1)

@vladak Please review

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 16, 2024
@vladak
Copy link
Member

vladak commented Dec 2, 2024

Looks good, although I am surprised there is no change to the test data.

@vladak
Copy link
Member

vladak commented Dec 5, 2024

Looks good, although I am surprised there is no change to the test data.

I mean - if the change broke Fortran, there should be some sort of test case to cover this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants