Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace URL() constructors #4750

Merged
merged 17 commits into from
Apr 8, 2025
Merged

replace URL() constructors #4750

merged 17 commits into from
Apr 8, 2025

Conversation

vladak
Copy link
Member

@vladak vladak commented Apr 1, 2025

This change gets rid of the URL() constructors deprecated in Java 20 and addresses a case of unescaped patterns.

Background: https://gist.github.com/vladak/beb43b9056b546869196d09a16542466

Approaches #4459 and takes over the URL() changes from @tarzanek's PR #4570

I had to add a flake8 suppression to the Docker entry point to make the build pass.

Tested with this read-only configuration:

<?xml version="1.0" encoding="UTF-8"?>
<java version="1.8.0_121" class="java.beans.XMLDecoder">
 <object class="org.opengrok.indexer.configuration.Configuration">

  <void property="bugPage">
   <string>https://github.com/apache/lucene/issues/</string>
  </void>

  <void property="bugPattern">
   <string>LUCENE-(\d+)</string>
  </void>

 </object>
</java>

and The Lucene Git repository.

@vladak vladak requested a review from ginoaugustine April 1, 2025 09:19
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 1, 2025
Copy link
Member

@ginoaugustine ginoaugustine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladak vladak merged commit 9de071f into oracle:master Apr 8, 2025
8 checks passed
@vladak vladak deleted the url_vs_uri branch April 8, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants