Skip to content

Log errors when ignorezeroresult = true #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
redelang opened this issue Dec 19, 2024 · 0 comments · Fixed by #173
Closed

Log errors when ignorezeroresult = true #168

redelang opened this issue Dec 19, 2024 · 0 comments · Fixed by #173

Comments

@redelang
Copy link

When ignorezeroresult is set to true, all errors are suppressed (also connection errors and such). It would be great if only the error coming from an actual zero result was suppressed.

See

oracle-db-appdev-monitoring/collector/collector.go

Line 356 in 06405fc

if !metric.IgnoreZeroResult {
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log errors when ignoreZeroResult = true oracle/oracle-db-appdev-monitoring
1 participant
@redelang