#181 issue

[rlagyu0]

issue 181

[oracle-contributor-agreement]

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

• PR author: rlagyu0
• 01086055223@hanmail.net (@kimgy0)

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

[anders-swanson]

@rlagyu0, could you please sign the OCA? Thank you.

[anders-swanson]

I think you're on the right track here, but this moves shared memory access outside the mutex boundary. I think we need to refactor this method and goroutine closure to properly synchronize the errors and provide an accurate count of errors in the defer method. Likely this should be handled with an error channel, so we can collect all errors that occurred in the goroutine and remove shared memory access entirely.

[rlagyu0]

What happens if the content of err is changed by another goroutine after this method? It seems like this could also be a partial error. As you mentioned, I’ve placed logic in defer to handle both scrape errors and single errors. What do you think of this approach?

Please take a look at the next commit.

commit 6b775c6

[anders-swanson]

This is looking better, definitely an improvement over the original code. Thanks for incorporating an error channel!

I'd like to take this commit once we get the CLA issue sorted, and we can further optimize/clean-up this concurrent section from there.

[rlagyu0]

@rlagyu0, could you please sign the OCA? Thank you.
i already send one request

[LesiaChaban]

Hi @rlagyu0, your OCA approved, but since your email 01086055223@hanmail.net associated with https://github.com/kimgy0 account but not with https://github.com/rlagyu0 the check failed. Please resign commit using kimgy0 account or associate the email with rlagyu0 account.

[rlagyu0]

Hi @rlagyu0, your OCA approved, but since your email 01086055223@hanmail.net associated with https://github.com/kimgy0 account but not with https://github.com/rlagyu0 the check failed. Please resign commit using kimgy0 account or associate the email with rlagyu0 account.

I have unlinked the email 01086055223@hanmail.net from the previous account rlagy0. It is now linked to my current account, rlagyu0, and is being used as the primary email.

[LesiaChaban]

See your PR signed by two your accounts

The following contributors of this PR have not signed the OCA:

- PR author: rlagyu0

- [01086055223@hanmail.net](mailto:01086055223@hanmail.net) (@kimgy0) 

The OCA check passed only for [01086055223@hanmail.net](@kimgy0) but not for rlagyu0.
You need to amend your commits only for one author or create a new PR where you will commit using only rlagyu0 or kimgy0 account

[markxnelson]

approving in order to run oca check again, with override.
please continue to work with anders on the implementation