Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roda CI now failing on TruffleRuby-head #3257

Closed
eregon opened this issue Sep 12, 2023 · 3 comments
Closed

Roda CI now failing on TruffleRuby-head #3257

eregon opened this issue Sep 12, 2023 · 3 comments
Assignees
@andrykonchin
Labels
compatibility
Milestone
24.0.0 Release (M...

Comments

@eregon
Copy link
Member

eregon commented Sep 12, 2023

From @jeremyevans:

FYI, Roda CI now failing on TruffleRuby-head. Looks like the cause is TruffleRuby is now advertising Ruby 3.2.2 without implementing Exception#detailed_message. https://github.com/jeremyevans/roda/actions/runs/6149810627/job/16686430579#step:4:16
@eregon
Copy link
Member Author

eregon commented Sep 12, 2023

Due to https://github.com/jeremyevans/roda/blob/7c8d3190b52a060d0e80ef7b977f41f48147780c/lib/roda/plugins/exception_page.rb#L414-L417.
That could use Exception.method_defined?(:detailed_message) instead to be more robust.

But of course we should also implement detailed_message (likely fairly easy)

eregon added a commit to eregon/roda that referenced this issue Sep 13, 2023
@eregon
Use feature detection to find out if detailed_message is available
efaf97b 
* See oracle/truffleruby#3257
@eregon eregon mentioned this issue Sep 13, 2023
Merged
@eregon
Copy link
Member Author

eregon commented Sep 13, 2023

PR to use feature detection in Roda so it works for 23.1: jeremyevans/roda#333

@graalvmbot graalvmbot mentioned this issue Sep 15, 2023
Merged
@eregon
Copy link
Member Author

eregon commented Sep 16, 2023

Fixed by b4a05b5

@eregon eregon closed this as completed Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrykonchin andrykonchin

Labels
compatibility
Projects
None yet
Milestone
24.0.0 Release (March 19, 2024)
Development

No branches or pull requests
2 participants
@eregon @andrykonchin