Coercion fixes for TCPServer.new

[XrXr]

Handle nil and empty string and coerce the port number the way MRI does.

Shopify#1

[graalvmbot]

Hello Alan Wu, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address xrxr -(at)- users -(dot)- noreply -(dot)- github -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

[graalvmbot]

Alan Wu has signed the Oracle Contributor Agreement (based on email address xrxr -(at)- users -(dot)- noreply -(dot)- github -(dot)- com) so can contribute to this repository.

[eregon]

Do you think we could model this more simply by using:

def initialize(host = nil, service)

It seems that if we are using just 1 argument, it's always for the service and host being nil/''.

[XrXr]

Thanks! I didn't think of using a trailing required arg. Actually, it seems that using

def initialize(host = nil, service)

we can simply delegate all the arguments to Socket like:

diff --git a/lib/truffle/socket/tcp_server.rb b/lib/truffle/socket/tcp_server.rb
index dcbb7dbeff..76e6e86197 100644
--- a/lib/truffle/socket/tcp_server.rb
+++ b/lib/truffle/socket/tcp_server.rb
@@ -27,37 +27,9 @@
 class TCPServer < TCPSocket
   NOT_PASSED = Object.new

-  def initialize(host, service = NOT_PASSED)
+  def initialize(host = nil, service)
     @no_reverse_lookup = self.class.do_not_reverse_lookup

-    if NOT_PASSED.equal?(service)
-      service =
-        if host.is_a?(Integer)
-          host
-        else
-          string_service = Truffle::Socket.coerce_to_string(host)
-          begin
-            Integer(string_service)
-          rescue ArgumentError
-            raise SocketError, "invalid port number: #{host}"
-          end
-        end
-
-      host = nil
-    end
-
-    service = 0 if service.nil?
-
-    unless service.is_a?(Integer)
-      service = Truffle::Socket.coerce_to_string(service)
-    end
-
-    if host
-      host = Truffle::Socket.coerce_to_string(host)
-    else
-      host = ''
-    end
-
     remote_addrs = Socket
       .getaddrinfo(host, service, :UNSPEC, :STREAM, 0, Socket::AI_PASSIVE)

Does this sound better? MRI does something similar.

[eregon]

Yes, that sounds great, could you update the PR with that?

[XrXr]

Updated.

[eregon]

The specs look great 👍

[eregon]

Excellent, a lot less code and a lot more correct :)