Make it possible to call instance_exec with rb_block_call #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instance_exec switches self, which breaks the `RARRAY_PTR` call we were making inside the block where we are unsure about what `self` is. While we are at it, add a spec for the last argument of rb_block_call.
aardvark179
approved these changes
Nov 7, 2019
eregon
reviewed
Nov 7, 2019
| object.__send__(method, *args) do |*block_args| | ||
| TrufflePrimitive.cext_unwrap(TrufflePrimitive.call_with_c_mutex(func, [ | ||
| TrufflePrimitive.cext_wrap(block_args.first), | ||
| data, | ||
| block_args.size, # argc | ||
| RARRAY_PTR(block_args), # argv | ||
| outer_self.RARRAY_PTR(block_args), # argv |
There was a problem hiding this comment.
Could you use an explicit Truffle::CExt.RARRAY_PTR(block_args) here?
There was a problem hiding this comment.
I'll make that change as it's a minor thing.
eregon
approved these changes
Nov 7, 2019
graalvmbot
pushed a commit
that referenced
this pull request
Nov 7, 2019
…1802). PullRequest: truffleruby/1124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instance_exec switches self, which breaks the
RARRAY_PTRcall we weremaking inside the block where we are unsure about what
selfis. Whilewe are at it, add a spec for the last argument of rb_block_call.
Shopify#1