Fix 'OpenSSL::Digest.{digest,hexdigest,base64digest} algorithm, data'

[bdewater]

I ran into digest not working while testing webauthn-ruby at 9b08086b. The test suite failed with examples such as:

  1) WebAuthn::AuthenticatorAttestationResponse when TPM attestation verifies
     Failure/Error: OpenSSL::Digest.digest(cose_algorithm.hash_function, att_to_be_signed)
     
     ArgumentError:
       wrong number of arguments (given 2, expected 1)
     # /Users/chrisseaton/src/github.com/Shopify/graal-shopify/sdk/mxbuild/darwin-amd64/GRAALVM_UNKNOWN_JAVA8_STAGE1/graalvm-unknown-java8-20.0.0-dev/Contents/Home/jre/languages/ruby/lib/truffle/digest.rb:139:in `digest'
     # /Users/chrisseaton/src/github.com/Shopify/graal-shopify/sdk/mxbuild/darwin-amd64/GRAALVM_UNKNOWN_JAVA8_STAGE1/graalvm-unknown-java8-20.0.0-dev/Contents/Home/jre/languages/ruby/lib/mri/openssl/digest.rb:35:in `digest'
     # ./lib/webauthn/attestation_statement/tpm.rb:27:in `valid?'
     # ./lib/webauthn/attestation.rb:35:in `valid_attestation_statement?'

While fixing this particular error I also noticed hexdigest and base64digest not working as expected, so I fixed these as well. More details are in the commit messages.

Shopify#1

[graalvmbot]

Hello Bart de Water, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address bart -(dot)- dewater -(at)- shopify -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

[graalvmbot]

Bart de Water has signed the Oracle Contributor Agreement (based on email address bart -(dot)- dewater -(at)- shopify -(dot)- com) so can contribute to this repository.

[eregon]

This looks great, thank you for the fix, I'll integrate it.

[eregon]

Digest.hexdigest seems defined as Digest.hexencode(Digest::Class.digest(*args)) in MRI:
https://github.com/ruby/ruby/blob/37c2cd3fa47c709570e22ec4dac723ca211f423a/ext/digest/digest.c#L478-L490

And then

truffleruby/lib/mri/openssl/digest.rb

Lines 34 to 36 in 59b78fd

	def self.digest(name, data)
	super(data, name)
	end

is what, very confusingly, swaps the arguments.

I'll add a commit to do that.

[bdewater]

Yes this definitely was a brainbender 😅 also had a fun time with how Digest::Class and Digest::Instance are used depending on using the stdlib Digest or the OpenSSL algorithm modules:

OpenSSL::Digest::SHA256.ancestors
=> [OpenSSL::Digest::SHA256, OpenSSL::Digest, Digest::Class, Digest::Instance, Object, Kernel, BasicObject]

Digest::SHA256.ancestors
=> [Digest::SHA256, Digest::Base, Digest::Class, Digest::Instance, Object, Kernel, BasicObject]

Digest::SHA256.ancestors - OpenSSL::Digest::SHA256.ancestors
=> [Digest::SHA256, Digest::Base]

[eregon]

Just a note: this was already defined at line 29 above:
https://github.com/oracle/truffleruby/pull/1889/files#diff-048c3691437021dc9c9997d1a3aa7792R29

This file is pretty hard to follow due to reopening classes and part of the code from MRI.
Maybe I should try to convince MRI devs to define more of Digest in Ruby :)

[eregon]

Merged in 619ad90, thank you!