Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement and untag Enumerable#tally #2144

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Implement and untag Enumerable#tally #2144

merged 2 commits into from
Nov 11, 2020

Conversation

LillianZ
Copy link
Contributor

Implements Enumerable#tally for Ruby 2.7 compatibility #2004

Shopify#1

eregon
eregon approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Nov 10, 2020
@eregon
Copy link
Member

eregon commented Nov 10, 2020

A very minor thing: feel free to untag in the same commit as implementing.
Not worth changing for this PR, it's fine.

@graalvmbot graalvmbot merged commit 8068ead into oracle:master Nov 11, 2020
@LillianZ LillianZ deleted the Enumerable#tally branch November 11, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
in-ci The PR is being tested in CI. Do not push new commits. oca-signed shopify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LillianZ @eregon @chrisseaton @graalvmbot