Skip to content

Ruby 2.7: Comment lines can be placed between fluent dot now #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ssnickolay
Copy link
Collaborator

@ssnickolay ssnickolay commented Nov 25, 2020

Related to #2004

The MRI commit: ruby/ruby@3a3f48f

Btw, should we unexclude test_syntax.rb (tag only individual failed tests)? The file completely disabled by failing.exclude but it is runnable:

jt test test/mri/tests/ruby/test_syntax.rb

Finished tests in 106.157000s, 1.0550 tests/s, 10.3620 assertions/s.
112 tests, 1100 assertions, 26 failures, 3 errors, 0 skips

@eregon
Copy link
Member

eregon commented Nov 25, 2020

Btw, should we unexclude test_syntax.rb (tag only individual failed tests)? The file completely disabled by failing.exclude but it is runnable:

Yes, that's a good thing if it works and if we can exclude the failures (there is tool/parse_mri_errors.rb for convenience + jt retag).

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Nov 25, 2020
@graalvmbot graalvmbot merged commit 7589239 into oracle:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-ci The PR is being tested in CI. Do not push new commits. oca-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants