[3.2 compatibility] Return nil for beginless ranges where the end is not numeric #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
rwstauner
changed the title
rwstauner
changed the title
andrykonchin
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Looks good 👍 . Thank you.
I suppose it's related to https://bugs.ruby-lang.org/issues/18983. It's helpful to have a reference to the original issue (or point at an issue in the Ruby release/NEWS document) in the PR to understand what it is about.
andrykonchin
added
the
in-ci
andrykonchin
force-pushed
the
rwstauner/ruby3.2-beginless-size-nil
branch
from
f0f05e9 to
0739ce4
Compare
|
I've rebased on master, added some commits and pushed to the branch. |
eregon
force-pushed
the
rwstauner/ruby3.2-beginless-size-nil
branch
from
0739ce4 to
3446588
Compare
Thanks, i saw this in the ruby changes but didn't look into where it came from. I'll dig further next time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3039
This is for ruby 3.2 (TODO: change merge target)
I changed the spec descriptions to match the code... let me know if you think something isn't right about that.