Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Accept options argument to Regexp.{new,compile} of String; Warn for unknown types #3411

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

rwstauner
Copy link
Collaborator

@rwstauner rwstauner commented Jan 25, 2024

Regexp.new now supports passing the regexp flags not only as an Integer,
but also as a String. Unknown flags raise ArgumentError.
Otherwise, anything other than true, false, nil or Integer will be warned.
[Feature #18788]

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 25, 2024
@rwstauner rwstauner changed the title [Compatibility] Accept options argument to Regexp#{new,compile} of String; Warn for unknown types [Compatibility] Accept options argument to Regexp.{new,compile} of String; Warn for unknown types Jan 26, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
src/main/ruby/truffleruby/core/regexp.rb Outdated Show resolved Hide resolved
@andrykonchin
Copy link
Member

CI failures seem irrelevant to the changes.

@eregon
Copy link
Member

eregon commented Jan 26, 2024

CI failures seem irrelevant to the changes.

Right, it seems related to a new ECJ in latest mx. And the workflow here just uses latest mx instead of the one specified in common.json. Maybe we should try to use the correct mx in GitHub Actions too.
But anyway we need to fix these ECJ warnings, I'll do it.
EDIT: we need to wait for oracle/graal#8260

src/main/ruby/truffleruby/core/regexp.rb Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@andrykonchin andrykonchin added the in-ci The PR is being tested in CI. Do not push new commits. label Jan 29, 2024
@graalvmbot graalvmbot merged commit 26a442b into oracle:master Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-ci The PR is being tested in CI. Do not push new commits. OCA Verified All contributors have signed the Oracle Contributor Agreement. shopify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants