Add a tool to generate the native configuration #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The generator relies on it.
* It is a pointer (represented as a NativePointer by NFI) on Darwin.
* It also seems not defined on Linux.
* Add Rubinius::Config#lookup for fetch value or nil. * The type of a struct field is optional for a FFI::Struct with config. * Define Process::RLIMIT_* constants only if they are available.
|
@chrisseaton Could you run |
chrisseaton
approved these changes
Nov 28, 2017
nirvdrum
approved these changes
Nov 28, 2017
|
Now that we have more control over the generation of these files, it could be valuable to make a map with ropes instead. We currently have to do a fair bit of work scanning byte arrays at startup. But we can handle that in a future PR. |
|
@nirvdrum Yes, we can do many more things :) This PR is about replacing the external process and making it easy to extend what we generate, but not yet extending it. |
* From the Fedora 26 Docker image in tool/docker/fedora.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.javafile (previously they were set to 0).Rubinius::Config[key]raises a KeyError if key does not exist. UseRubinius::Config#lookupif you want value-or-nil semantics.