Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issue 143: make PID works in forked repo #144

Merged
merged 3 commits into from
May 27, 2022
Merged

Address issue 143: make PID works in forked repo #144

merged 3 commits into from
May 27, 2022

Conversation

zhengchang907
Copy link

@zhengchang907 zhengchang907 commented May 26, 2022 •
edited
Loading

#143

Changes:

  • Make PID works in forked repo
    • Update pom.xml files to parameterized PID reference
    • Update pipelines to pass parameters of forked repo
  • Support both workflow_dispatch and repo_dispatch for buildWlsVm4AsArtifact.yml and testWlsVmAdmin.yml
  • Update Admin offer version
  • Improvement and bugs found by PR and addressed
    • Improve URL creation in templates based on errors got from arm-ttk, related issue
    • Upgrade Key Vault API version based on arm-ttk error, add private end point to Oracle pid
    • Located a bug and fixed: unused logic broke accessing admin console via port 7005

Test:

  • Pipelines
  • Admin offer
    • Template deployment cases
      • No SSL, new VNET
      • No SSL, existing VNET(use zheng-private-vnet)
      • SSL, new VNET
      • SSL, existing VNET(use zheng-private-vnet)
    • Private offer deployment cases
      • No SSL, new VNET
      • No SSL, existing VNET(use zheng-private-vnet)
      • SSL, new VNET
      • SSL, existing VNET(use zheng-private-vnet)

@zhengchang907 zhengchang907 changed the title issue 143: make PID works in forked repo Address issue 143: make PID works in forked repo May 26, 2022
edburns
edburns suggested changes May 26, 2022
View reviewed changes
Copy link
Contributor

@edburns edburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments inline.

@edburns
Copy link
Contributor

edburns commented May 26, 2022

@zhengchang907 please change this to a draft PR while the review comments are being addressed.

@edburns edburns force-pushed the pipelineissue143 branch from 22cacf7 to 0e7ec27 Compare May 26, 2022 16:17
@zhengchang907 zhengchang907 marked this pull request as draft May 27, 2022 00:56
@zhengchang907 zhengchang907 marked this pull request as ready for review May 27, 2022 02:49
@mriccell mriccell merged commit 97af0af into oracle:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mriccell mriccell mriccell approved these changes

@edburns edburns edburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhengchang907 @edburns @mriccell