OWLS-72816 Generate event and status when operator can't scale cluster past maximum #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not valid for the weblogic cluster
tbarnes-us
reviewed
Dec 14, 2020
operator/src/main/java/oracle/kubernetes/operator/steps/ManagedServersUpStep.java
Outdated
Show resolved
Hide resolved
rjeberhard
approved these changes
Dec 17, 2020
doxiao
reviewed
Dec 17, 2020
| @@ -242,6 +243,39 @@ Source: | |||
| Type: Warning | |||
| Events: <none> | |||
|
|
|||
| ``` | |||
| Example of a `InvalidReplicasValue` event: | |||
There was a problem hiding this comment.
change InvalidReplicasValue to DomainValidationError?
There was a problem hiding this comment.
thanks. updated with example of DomainValidationError.
doxiao
approved these changes
Dec 18, 2020
|
@tbarnes-us, are your concerns addressed? |
tbarnes-us
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a replicas value is below the configured min cluster size, or above the configured max cluster size, generate events such as:
Also update
status.messageof the domain resource to:Also include in the PR a fix for a bug that was found in validation of
serverNameof specified inmanagedServer, in that a validation warning message such as the following is added even though the server name exists in a dynamic cluster:"Managed Server 'managed-server1' specified in the domain resource does not exist in the WebLogic domain home configuration."https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/3334/