Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate authorization checks for the operator and domain namespaces #2138

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

rjeberhard
Copy link
Member

We have functionality in the HealthCheckHelper class that verifies that the operator has all of the necessary privileges in each namespace in order to do its work. This code had been previously cleaned-up, but in that rewrite an important distinction was lost.

Specifically, that the privileges needed in the operator's own namespace (as opposed to those needed in some domain namespace) are different and that if the operator's own namespace is also a domain namespace then both sets of privileges are required.

I noticed that most operator logs had a lot of WARNING statements from these authorization checks... The reason was that the HealthCheckHelper was looking for domain namespace privileges for the operator's namespace.

Finally, I cleaned-up just a little the set of roles needed for the operator's namespace.

@lennyphan
Copy link
Member

Are docs/charts/index.yaml and docs/charts/weblogic-operator-3.2.0.tgz supposed to be part of the PR?

Copy link
Member

@lennyphan lennyphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my question on whether 'docs/charts/index.yaml' and 'docs/charts/weblogic-operator-3.2.0.tgz' should be part of the PR, the rest of the changes LGTM.

@rjeberhard
Copy link
Member Author

rjeberhard commented Jan 13, 2021

Are docs/charts/index.yaml and docs/charts/weblogic-operator-3.2.0.tgz supposed to be part of the PR?

@lennyphan, yeah they are... I made a change to files under kubernetes/charts/weblogic-operator and this is sufficient to trigger the build of these files.

Copy link
Member

@ankedia ankedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if there should be a unit test added for operator-only namespace access (when isDomainNamespace is false). Otherwise it looks good to me.

@rjeberhard rjeberhard merged commit 5cfb14c into develop Jan 14, 2021
@rjeberhard rjeberhard deleted the authz-warnings branch January 31, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants