You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owls 87209 - Domain lifecycle scripts fix in cases where domain/cluster specs are overridden at the individual managed server level. The script doesn't work correctly when .spec.managedServers section has pre-existing details for a particular managed server. For e.g Consider the below stanza where the serverStartState attribute is overridden for soa_server1.
spec:
managedServers:
serverName: soa_server1
serverStartState: RUNNING
This change adds the server start policy element for the managed server if the policy doesn't exist or replaces the policy if the policy already exists. Similarly, it unsets the policy and/or deletes the managed server element if managed server spec only has serverStartPolicy under it.
General comment: IIRC, there are integration tests for these scripts. If so, please file a JIRA to enhance them to cover the new use case...
Thanks. I have made the suggested changes and also created JIRA OWLS-87819 to track the enhancement of the integration tests to cover the new use case.
Can you enhance integration test (ItServerStartPolicy.java) to add this usecase.
I have created JIRA OWLS-87819 to track the integration test enhancement and it can be done in a separate PR. Do we have any other integration tests where domain/cluster specs are overridden at the managed server level?
.. Can you enhance integration test (ItServerStartPolicy.java) to add this usecase.
. I have created JIRA OWLS-87819 to track the integration test enhancement and it can be done in a separate PR.
Thanks.
. Do we have any other integration tests where domain/cluster specs are overridden at the managed server level?
I don't know, Pani might.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owls 87209 - Domain lifecycle scripts fix in cases where domain/cluster specs are overridden at the individual managed server level. The script doesn't work correctly when
.spec.managedServerssection has pre-existing details for a particular managed server. For e.g Consider the below stanza where theserverStartStateattribute is overridden for soa_server1.spec:
managedServers:
serverStartState: RUNNING
This change adds the server start policy element for the managed server if the policy doesn't exist or replaces the policy if the policy already exists. Similarly, it unsets the policy and/or deletes the managed server element if managed server spec only has serverStartPolicy under it.