Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't roll on upgrades from 3.0 #2292

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Don't roll on upgrades from 3.0 #2292

merged 2 commits into from
Mar 31, 2021

Conversation

russgold
Copy link
Member

Takes into consideration that in 3.0, the prometheus annotations were computed differently than in 3.1.

@russgold russgold self-assigned this Mar 31, 2021
@rjeberhard rjeberhard changed the base branch from master to develop March 31, 2021 14:50
@rjeberhard rjeberhard mentioned this pull request Mar 31, 2021
Closed
jshum2479
jshum2479 reviewed Mar 31, 2021
View reviewed changes
Copy link
Member

@jshum2479 jshum2479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only comment I have is when a pod needs to be replaced because of domain zip hash changed, the operator logs a message "Replacing pod ... because of null" - is there a way to put the actual reason there?

@rjeberhard
Copy link
Member

LGTM, the only comment I have is when a pod needs to be replaced because of domain zip hash changed, the operator logs a message "Replacing pod ... because of null" - is there a way to put the actual reason there?

I'll file a bug, but I don't want to hold up an initial release. We've implemented a series of compatibility checks, which must not be complete. If none of them match then the result is "null".

@rjeberhard rjeberhard merged commit 235d392 into develop Mar 31, 2021
@russgold
Copy link
Member Author

LGTM, the only comment I have is when a pod needs to be replaced because of domain zip hash changed, the operator logs a message "Replacing pod ... because of null" - is there a way to put the actual reason there?

I'll file a bug, but I don't want to hold up an initial release. We've implemented a series of compatibility checks, which must not be complete. If none of them match then the result is "null".

Then do file a bug and we can deal with it in the next release. I have no test for this and did not notice it.

@russgold russgold deleted the match_3_0_pad_hash branch March 31, 2021 20:53
zhengchang907 pushed a commit to zhengchang907/weblogic-kubernetes-operator that referenced this pull request Oct 28, 2021
@russgold @rjeberhard
Don't roll on upgrades from 3.0 (oracle#2292)
87a0a2e 
* Don't roll pods when upgrading from 3.0.*

* Take downtime for operator while updating image

Co-authored-by: Ryan Eberhard <ryan.eberhard@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshum2479 jshum2479 jshum2479 left review comments

@rjeberhard rjeberhard rjeberhard approved these changes

Assignees

@russgold russgold

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russgold @rjeberhard @jshum2479