OWLS-88569 add events for rolling restart #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doxiao
requested review from
russgold,
rjeberhard,
tbarnes-us,
rosemarymarano and
ankedia
tbarnes-us
reviewed
May 18, 2021
documentation/staging/content/userguide/managing-domains/domain-events.md
Outdated
Show resolved
Hide resolved
tbarnes-us
reviewed
May 18, 2021
documentation/staging/content/userguide/managing-domains/domain-events.md
Show resolved
Hide resolved
| * `DomainProcessingCompleted`: The operator successfully completed the processing of a domain resource. | ||
| * `DomainProcessingAborted`: The operator stopped processing a domain when the operator encountered a fatal error or a failure that persisted after the specified maximum number of retries. | ||
| * `DomainRollStarting`: The operator has started a rolling restart of a domain after it detects a change or changes in the domain resource or WebLogic domain configuration, which require a restart of all running pods in the domain. The operator makes its best efforts in providing the reason of the rolling restart. If the rolling restart is caused by one or more of the following fields in the domain resource, the event message contains the fields that have changed as well as their old and new values: image, imagePullPolicy, livenessProbe, readinessProbe, domain restartVersion, domainHome, includeServerOutInPodLog, and logHome. When the rolling restart is caused by changes in the other domain resource fields (Please refer to [Fields in domain resource that cause servers to be restarted]({{< relref "/userguide/managing-domains/domain-lifecycle/startup#fields-that-cause-servers-to-be-restarted" >}})), the event message simply indicates that the domain resource has changed. If the cause of the rolling restart is in the WebLogic domain configuration, the event message indicates that as well without the details. |
There was a problem hiding this comment.
the reason of the rolling restart -> the reason for the rolling restartimage, imagePullPolicy, livenessProbe, readinessProbe, domain restartVersion, domainHome, includeServerOutInPodLog, and logHome -> all the field names should be in code font: image, imagePullPolicy, livenessProbe, etc.
Please refer to -> see
indicates that as well without the details -> indicates that, as well, without the details
| * `DomainProcessingCompleted`: The operator successfully completed the processing of a domain resource. | ||
| * `DomainProcessingAborted`: The operator stopped processing a domain when the operator encountered a fatal error or a failure that persisted after the specified maximum number of retries. | ||
| * `DomainRollStarting`: The operator has started a rolling restart of a domain after it detects a change or changes in the domain resource or WebLogic domain configuration, which require a restart of all running pods in the domain. The operator makes its best efforts in providing the reason of the rolling restart. If the rolling restart is caused by one or more of the following fields in the domain resource, the event message contains the fields that have changed as well as their old and new values: image, imagePullPolicy, livenessProbe, readinessProbe, domain restartVersion, domainHome, includeServerOutInPodLog, and logHome. When the rolling restart is caused by changes in the other domain resource fields (Please refer to [Fields in domain resource that cause servers to be restarted]({{< relref "/userguide/managing-domains/domain-lifecycle/startup#fields-that-cause-servers-to-be-restarted" >}})), the event message simply indicates that the domain resource has changed. If the cause of the rolling restart is in the WebLogic domain configuration, the event message indicates that as well without the details. | ||
| * `DomainRollCompleted`: The operator has successfully completed a rolling restart of a domain. | ||
| * `PodCycleStarting`: The operator has started to replace a server pod after it detects that the current pod is not conformed to the current domain resource or WebLogic domain configuration. |
There was a problem hiding this comment.
the current pod is not conformed -> the current pod does not conform
|
|
||
| Example of the sequence of operator generated events in a domain rolling restart after the domain resource's `image` and `logHomeEnabled` changed. | ||
|
|
||
| The output of command `kubectl get events -n sample-domain1-ns --selector=weblogic.domainUID=sample-domain1,weblogic.createdByOperator=true --sort-by=lastTimestamp'. |
There was a problem hiding this comment.
output of command -> output of the command
Instead of a period at the end of this phrase (it is not not a complete sentence), it should be a colon.
tbarnes-us
reviewed
May 18, 2021
documentation/staging/content/userguide/managing-domains/domain-events.md
Outdated
Show resolved
Hide resolved
rosemarymarano
approved these changes
May 18, 2021
rjeberhard
approved these changes
May 18, 2021
tbarnes-us
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test passed in Jenkins: https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5005/.