Consistently use ISO-8601 date time format #2386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@tbarnes-us, I've updated the scripts and WLST to as closely as possible match the timestamps that the operator generates. @ankedia, I know you are away today, but next week can you please take a look at this? Tom noted that you may have timing scripts that depend on the format of timestamps. |
tbarnes-us
reviewed
May 28, 2021
operator/src/main/java/oracle/kubernetes/operator/logging/LoggingFormatter.java
Show resolved
Hide resolved
tbarnes-us
reviewed
May 28, 2021
tbarnes-us
reviewed
May 28, 2021
tbarnes-us
reviewed
May 28, 2021
tbarnes-us
reviewed
May 28, 2021
tbarnes-us
reviewed
Jun 1, 2021
ankedia
approved these changes
Jun 1, 2021
Member
ankedia
left a comment
ankedia
left a comment
There was a problem hiding this comment.
LGTM. As I mentioned, the timing scripts are not actively being used and I can tweak them to match the new format if needed.
tbarnes-us
approved these changes
Jun 1, 2021
ddsharpe
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.