Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/loading init common #1113

Merged
merged 7 commits into from
Jan 3, 2025
Merged

Feat/loading init common #1113

merged 7 commits into from
Jan 3, 2025

Conversation

trungbach
Copy link
Contributor

This pull request includes several changes aimed at improving the codebase by adding new imports, removing unused code, and enhancing the initialization process. Below is a summary of the most important changes:

Codebase Simplification and Cleanup:

  • Removed unused imports and reorganized existing imports in src/helper/index.tsx to streamline the code.
  • Deleted the findChainByChainId function from src/helper/index.tsx as it was no longer needed.
  • Removed the import of findChainByChainId and other unused imports from src/pages/Balance/TransferConvertToken/index.tsx. [1] [2]

Initialization Enhancements:

  • Improved the initialization process of oraidexCommon in src/initCommon.ts by adding a retry mechanism to ensure it loads successfully.

Miscellaneous Changes:

  • Added a LoadingPage component import to src/layouts/App.tsx and commented out an interval setup in the useEffect hook. [1] [2]
  • Added an event listener for the load event to log a message when the window loads in src/index.tsx.

Copy link

cloudflare-workers-and-pages bot commented Jan 3, 2025

Deploying beta-oraidex with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2e72f27
Status: ✅  Deploy successful!
Preview URL: https://b0917ffa.beta-oraidex.pages.dev
Branch Preview URL: https://develop-v3.beta-oraidex.pages.dev

View logs

vuonghuuhung
vuonghuuhung previously approved these changes Jan 3, 2025
@trungbach trungbach merged commit 016174f into main Jan 3, 2025
1 of 2 checks passed
@trungbach trungbach deleted the feat/loading-init-common branch February 12, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants