Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added quoted tweets to conversation command #237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nealchandra
Copy link

This PR updates the conversation command to include quoted tweets in the conversation history instead of replies only. Many users tend to use quotes as an alternative way to reply to/comment on a thread, so conversation seemed like the appropriate command to piggyback on. I noticed a few folks had requested this in #227, and the change was fairly straightforward so I thought putting it in a PR might be useful to others.

@nealchandra nealchandra changed the title Added quoted tweets to conversation command Added quoted tweets to conversation command May 30, 2017
Copy link
Owner

@orakaro orakaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't mix up the logic of finding quoted tweets and finding the chain of the replied tweets. Can we do this after L602 against thread_ref directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants