Changed default location of completer.hist #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to conflict with #233 My way has the advantage, that the file is hidden away by default, but the place stays still easily configurable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #231, I changed the default value of the HISTORY_FILENAME config key to "", and wrote a small function to check if the value is empty, and replacing it with "/home/$USER/.local/share/rainbow.hist" instead.
This should remove a lot of unnecessary clutter from user's working directorys, as the completer.hist file was a bit annoying, and also unifies the history in one place, leading to a consistent history.