Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build image.c as an extension; Fixed Windows support #256

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ptytb
Copy link

@ptytb ptytb commented Mar 1, 2018

I've been having installing and functioning issues on Windows, now it seem to work fine.

I tried to do some things more cross-platform way.

I'm running rainbowstream on ConEmu terminal for Windows and commands do work, images are rendering.

Update: I've just tested it on Debian Jessie, it compiles and works.

@ptytb ptytb mentioned this pull request Mar 30, 2018
@orakaro
Copy link
Owner

orakaro commented Apr 19, 2018

Gonna give this a test in next version release. Thanks for your effort!

@dogancelik
Copy link

It installs without any error, thank you @ptytb

# pip install git+https://github.com/ptytb/rainbowstream.git
Collecting git+https://github.com/ptytb/rainbowstream.git
…
Requirement already satisfied: python-dateutil 
Requirement already satisfied: arrow 
Requirement already satisfied: requests==2.5.3 
Requirement already satisfied: pyfiglet 
Requirement already satisfied: twitter 
Requirement already satisfied: Pillow 
Requirement already satisfied: PySocks 
Requirement already satisfied: pocket 
Collecting pyreadline (from rainbowstream==1.3.7)
…
Successfully built rainbowstream pyreadline
Installing collected packages: pyreadline, rainbowstream
  Found existing installation: rainbowstream 1.4.0
    Uninstalling rainbowstream-1.4.0:
      Successfully uninstalled rainbowstream-1.4.0
Successfully installed pyreadline-2.1 rainbowstream-1.3.7

Then I start:

# rainbowstream
RainbowStream latest version is 1.4.0 while your current version is 1.3.7
You should upgrade with pip install -U rainbowstream

Need tips ? Type "h" and hit Enter key!
[@dogancelik]:
We have connection problem with twitter stream API right now :(
☺☻[@dogancelik]: ☺☻

But I get a connection problem after starting rainbowstream, maybe it will be fixed after I upgrade to version 1.4.0.

Can you merge this? @orakaro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants