fix: check for hrtime func availability #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @castarco ! |
codyzu
reviewed
Aug 24, 2022
| @@ -35,7 +35,7 @@ export function formatNanoseconds(value: number | bigint): string { | |||
| } | |||
|
|
|||
| export function getNanosecondsTime(): bigint { | |||
| if (typeof process !== "undefined") { | |||
| if (typeof process !== "undefined" && process.hrtime !== undefined) { | |||
There was a problem hiding this comment.
it feels a little inconsistent here... do we need an issue to use !== undefined everywhere? Using typeof x !== "string" feels kind of old school, right???
There was a problem hiding this comment.
The first part of the conditional makes sense because, if process is not declared (as opposed to be undefined), then comparing it against undefined, or trying to do something like if (process), will raise an error (I actually tried it this morning).
It is true, though, that the second part of the conditional could have been simplified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101