-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed intersectMany function #160
Conversation
This change fixes issue oramasearch#159. The previous intersectMany method was not finding the correct occurrences.
This is good, thank you so much! Thanks! |
Done 👍🏻 Let me know if you need anything else. Grazie! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments, could you please add tests on array intersection specifically?
Something like:
const arr1 = [1,2,3]
const arr2 = [2,3,4]
const intersection = intersectMany(arr1, arr2) // 2,3
thanks!
updated tests for oramasearch#159
I've just added the requested test. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments, remember to run the linter before committing 🙂
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
This change fixes issue #159.
The previous intersectMany method was not finding the correct occurrences.