chore: refactor #166
Merged
chore: refactor #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelGSS
suggested changes
Oct 27, 2022
ilteoood
requested review from
RafaelGSS and
micheleriva
and removed request for
RafaelGSS and
micheleriva
RafaelGSS
approved these changes
Oct 28, 2022
| // Check if stop-words removal is enabled | ||
| if (tokenizerConfig?.enableStopWords) { | ||
| // Remove stop-words | ||
| if ((tokenizerConfig?.customStopWords as string[]).includes(token)) { |
There was a problem hiding this comment.
By the way, Array.prototype.includes is slow too. But it's out of the topic of this PR.
There was a problem hiding this comment.
@RafaelGSS true, but the thecustomStopWords array is typically pretty small, so it wouldn't affect the performance that much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactors while I was reading the code
@micheleriva