Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ukrainian language #252

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Ukrainian language #252

merged 4 commits into from
Jan 19, 2023

Conversation

lpite
Copy link
Contributor

@lpite lpite commented Jan 17, 2023

No description provided.

@lpite lpite changed the title Ukrinian language Ukrainian language Jan 17, 2023
@micheleriva
Copy link
Member

Hi @lpite
thank you so much, that looks fantastic! Would you mind adding some tests?

@lpite
Copy link
Contributor Author

lpite commented Jan 19, 2023

Hi @micheleriva, yes added tests.

micheleriva
micheleriva approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@micheleriva micheleriva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@micheleriva micheleriva merged commit c4b5140 into oramasearch:main Jan 19, 2023
@ilteoood ilteoood mentioned this pull request Jan 22, 2023
Closed
@optic-release-automation optic-release-automation bot mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micheleriva micheleriva micheleriva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpite @micheleriva