feat: add Bulgarian language stemmer #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also been looking into stop-words and wanted to check if we want to have a custom hardcoded solution like the currently available languages in the project, or if we're ok with importing a standard package like stopwords-iso, which has a variant for Bulgarian stopwords (which can also be imported standalone). |
|
@micheleriva Is there anything else required to push this over the line? |
micheleriva
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on the previous PR (#289), this PR adds a light stemmer for Bulgarian, based on the Java implementation found in Apache Lucene (repo, stemmer).
Note: as this is a light stemmer implementation (without a dictionary) there may be some edge cases of things not being covered, but it should suffice for most common use cases.