chore: use new searchbox #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
g-francesca
reviewed
Aug 13, 2024
packages/docs/astro.config.mjs
Outdated
| @@ -11,7 +11,7 @@ export default defineConfig({ | |||
| site: "https://docs.orama.com", | |||
| vite: { | |||
| ssr: { | |||
| noExternal: ['nanoid'] | |||
| noExternal: ['nanoid', '@orama/react-components'] | |||
There was a problem hiding this comment.
in memory of the hell behind this line.... 😄
g-francesca
reviewed
Aug 13, 2024
| api_key: 'NKiqTJnwnKsQCdxN7RyOBJgeoW5hJ594', | ||
| endpoint: 'https://cloud.orama.run/v1/indexes/orama-docs-bzo330' | ||
| }) | ||
| defineCustomElements() | ||
|
|
There was a problem hiding this comment.
- to be removed with the next release of
@orama/react-components
g-francesca
reviewed
Aug 13, 2024
| import { SearchBox, SearchButton } from '@orama/searchbox' | ||
| import '@orama/searchbox/dist/index.css' | ||
| import { OramaSearchBox, defineCustomElements } from '@orama/react-components' | ||
| import '@orama/react-components/dist/index.css' |
There was a problem hiding this comment.
style should be already bundled actually, if you remove this import I expect you to not have problems with style
g-francesca
reviewed
Aug 13, 2024
| eq: currentCategory | ||
| } | ||
| } | ||
| : {} |
There was a problem hiding this comment.
not sure, but maybe we don't need really need this if it's used for facets
- check if we need to add add this
where
There was a problem hiding this comment.
checked that we need it to filter between open source and cloud doc
This was referenced Sep 26, 2024
This was referenced Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new searchbox.
It has some issues, but next release should fix most of them.