Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cloudavenue_vm #286

Merged
merged 37 commits into from
Jun 16, 2023
Merged

refactor: cloudavenue_vm #286

merged 37 commits into from
Jun 16, 2023

Conversation

azrod
Copy link
Member

@azrod azrod commented Apr 13, 2023 •
edited by dmicheneau
Loading

Description of your changes

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

@crown-app
Copy link

crown-app bot commented Apr 13, 2023

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

@crown-app crown-app bot added Refactor size/XL Extra large PR labels Apr 13, 2023
@azrod azrod changed the title Refacto vm superschema refactor: cloudavenue_vm Apr 13, 2023
@azrod azrod force-pushed the refacto_vm_superschema branch 2 times, most recently from 470c29e to 581c2d5 Compare April 25, 2023 07:57
@crown-app crown-app bot added the Fix label Apr 26, 2023
@dmicheneau dmicheneau force-pushed the refacto_vm_superschema branch from 7e1de4b to accb5aa Compare April 27, 2023 14:27
@crown-app crown-app bot added Chore labels May 26, 2023
@dmicheneau dmicheneau force-pushed the refacto_vm_superschema branch from 47a80d7 to 3b8b4fe Compare June 6, 2023 14:31
azrod and others added 18 commits June 8, 2023 21:23
@azrod azrod force-pushed the refacto_vm_superschema branch from 39d4baf to c3bd524 Compare June 8, 2023 19:30
@crown-app crown-app bot removed the category/deps label Jun 8, 2023
@crown-app crown-app bot added the Feature label Jun 13, 2023
@azrod azrod force-pushed the refacto_vm_superschema branch from ea7f32f to 0c3a836 Compare June 14, 2023 14:34
@azrod azrod force-pushed the refacto_vm_superschema branch from 0c3a836 to 7100e85 Compare June 14, 2023 20:20
@azrod azrod marked this pull request as ready for review June 15, 2023 08:21
@azrod azrod force-pushed the refacto_vm_superschema branch from 767be24 to 0b538eb Compare June 15, 2023 14:01
dmicheneau
dmicheneau requested changes Jun 15, 2023
View reviewed changes
internal/client/vm.go Outdated Show resolved Hide resolved
internal/client/vm.go Outdated Show resolved Hide resolved
internal/client/vm.go Outdated Show resolved Hide resolved
internal/client/vm.go Outdated Show resolved Hide resolved
internal/provider/common/storageprofile/storage_profile.go Outdated Show resolved Hide resolved
internal/provider/vm/vm_disk_resource.go Outdated Show resolved Hide resolved
internal/provider/vm/vm_disk_resource.go Outdated Show resolved Hide resolved
internal/provider/vm/vm_disk_resource.go Outdated Show resolved Hide resolved
internal/provider/vm/vm_disk_schema.go Outdated Show resolved Hide resolved
internal/provider/vm/vm_schema.go Outdated Show resolved Hide resolved
@azrod azrod force-pushed the refacto_vm_superschema branch from 4987330 to 8532a48 Compare June 16, 2023 07:42
@dmicheneau dmicheneau merged commit 25abb26 into main Jun 16, 2023
@dmicheneau dmicheneau deleted the refacto_vm_superschema branch June 16, 2023 07:48
gaetanars pushed a commit that referenced this pull request Jun 16, 2023
chore: update CHANGELOG.md for #286
3bc5a34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmicheneau dmicheneau dmicheneau approved these changes

Assignees
No one assigned
Labels
size/XL Extra large PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azrod @dmicheneau