refactor: cloudavenue_vm

.changelog/286.txt

@@ -0,0 +1,23 @@
+```release-note:breaking-change
+New major change on schema for `cloudavenue_vm` resource.
+```
+
+```release-note:breaking-change
+Deletion of `power_on` attribute in schema for `cloudavenue_vapp` resource and datasource.
+```
+
+```release-note:breaking-change
+New major change on schema `cloudavenue_vm_disk` resource.
+```
+
+```release-note:bug
+Force to `power_off` a `cloudavenue_vapp` when you delete a `cloudavenue_vapp_org_network` resource.
+```
+
+```release-note:dependency
+deps: bumps github.com/FrangipaneTeam/terraform-plugin-framework-validators from 1.5.1 to 1.6.3
+```
+
+```release-note:dependency
+Update VMware Cloud Director API from v37.0 to v37.1
+```

.golangci.yml

@@ -10,7 +10,6 @@ linters:
     - bidichk # Checks for dangerous unicode character sequences [fast: true, auto-fix: false]
     - deadcode # Finds unused code [fast: false, auto-fix: false]
     - decorder # check declaration order and count of types, constants, variables and functions [fast: true, auto-fix: false]
-    - depguard # Go linter that checks if package imports are in a list of acceptable packages [fast: true, auto-fix: false]
     - dogsled # Checks assignments with too many blank identifiers (e.g. x, _, _, _, := f()) [fast: true, auto-fix: false]
     - durationcheck # check for two durations multiplied together [fast: false, auto-fix: false]
     - errcheck # Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases [fast: false, auto-fix: false]
@@ -38,7 +37,6 @@ linters:
     - ineffassign # Detects when assignments to existing variables are not used [fast: true, auto-fix: false]
     - makezero # Finds slice declarations with non-zero initial length [fast: false, auto-fix: false]
     - misspell # Finds commonly misspelled English words in comments [fast: true, auto-fix: true]
-    - nakedret # Finds naked returns in functions greater than a specified function length [fast: true, auto-fix: false]
     - nilerr # Finds the code that returns nil even if it checks that the error is not nil. [fast: false, auto-fix: false]
     - noctx # noctx finds sending http request without context.Context [fast: false, auto-fix: false]
     - nolintlint # Reports ill-formed or insufficient nolint directives [fast: true, auto-fix: false]
@@ -48,7 +46,6 @@ linters:
     - revive # Fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint. [fast: false, auto-fix: false]
     - rowserrcheck # checks whether Err of rows is checked successfully [fast: false, auto-fix: false]
     - sqlclosecheck # Checks that sql.Rows and sql.Stmt are closed. [fast: false, auto-fix: false]
-    - structcheck # Finds unused struct fields [fast: false, auto-fix: false]
     - stylecheck # Stylecheck is a replacement for golint [fast: false, auto-fix: false]
     - tagliatelle # Checks the struct tags. [fast: true, auto-fix: false]
     - tenv # tenv is analyzer that detects using os.Setenv instead of t.Setenv since Go1.17 [fast: false, auto-fix: false]
@@ -68,6 +65,9 @@ linters:
     - bodyclose # checks whether HTTP response body is closed successfully
 
   disable:
+    - structcheck # Finds unused struct fields [fast: false, auto-fix: false]
+    - nakedret # Finds naked returns in functions greater than a specified function length [fast: true, auto-fix: false]
+    - depguard # Go linter that checks if package imports are in a list of acceptable packages [fast: true, auto-fix: false]
     - goimports # In addition to fixing imports, goimports also formats your code in the same style as gofmt. [fast: true, auto-fix: true]
     - containedctx # containedctx is a linter that detects struct contained context.Context field [fast: true, auto-fix: false]
     - thelper # thelper detects golang test helpers without t.Helper() call and checks the consistency of test helpers [fast: false, auto-fix: false]

docs/data-sources/vapp.md

@@ -31,7 +31,6 @@ data "cloudavenue_vapp" "example" {
 - `description` (String) Description of the vApp.
 - `guest_properties` (Map of String) Key/value settings for guest properties.
 - `lease` (Attributes) Informations about vApp lease. (see [below for nested schema](#nestedatt--lease))
-- `power_on` (Boolean) A boolean value indicating whether this vApp is powered on or not.
 
 <a id="nestedatt--lease"></a>
 ### Nested Schema for `lease`

docs/resources/alb_pool.md

@@ -110,7 +110,7 @@ Required:
 
 Optional:
 
-- `value` (String) Value of attribute based on persistence type. If persistence_profile.type attribute is set and the value is one of `"HTTP_COOKIE"`, this attribute is required.
+- `value` (String) Value of attribute based on persistence type. If persistence_profile.type attribute is set and the value is one of `"HTTP_COOKIE"`, this attribute is REQUIRED.
 
 ## Import
 

docs/resources/vapp.md

@@ -40,7 +40,6 @@ resource "cloudavenue_vapp" "example" {
 - `description` (String) Description of the vApp.
 - `guest_properties` (Map of String) Key/value settings for guest properties.
 - `lease` (Attributes) Informations about vApp lease. Value defaults to `{"runtime_lease_in_sec":0,"storage_lease_in_sec":0}`. (see [below for nested schema](#nestedatt--lease))
-- `power_on` (Boolean) A boolean value indicating whether this vApp is powered on or not. Value defaults to `false`.
 - `vdc` (String) (ForceNew) The name of vDC to use, optional if defined at provider level.
 
 ### Read-Only

docs/resources/vapp_org_network.md

@@ -9,6 +9,10 @@ description: |-
 
 Provides a Cloud Avenue routed vAPP Org Network resource. This can be used to create, modify, and delete routed vAPP Network.
 
+!> **Warning on deleting resource:** Deleting a resource require **vApp to be in a powered OFF** state. 
+If the vApp is in a powered on state, the resource will power OFF the vApp before deleting the resource and then power it back on.
+On power **ALL** VMs in the vApp will be powered ON, regardless of their previous state.
+
 ## Example Usage
 
 ```terraform

docs/resources/vm_disk.md

@@ -2,12 +2,12 @@
 page_title: "cloudavenue_vm_disk Resource - cloudavenue"
 subcategory: "VM (Virtual Machine)"
 description: |-
-  The disk resource allows you to manage a disk in the vDC.
+  The virtual machine (vm) resource allows you to manage a virtual machine in the CloudAvenue.
 ---
 
 # cloudavenue_vm_disk (Resource)
 
-The disk resource allows you to manage a disk in the vDC.
+The virtual machine (vm) resource allows you to manage a virtual machine in the CloudAvenue.
 
 ## Example Usage
 
@@ -31,25 +31,25 @@ resource "cloudavenue_vm_disk" "example-detachable" {
 
 ### Required
 
-- `is_detachable` (Boolean) If the disk is detachable or not. If set to `true`, the disk will be attached to any VM that is created from the vApp. If set to `false`, the disk will be attached to the VM specified in `vm_name` or `vm_id`. Change this field requires a replacement of the disk.
-- `name` (String) The name of the disk.
+- `size_in_mb` (Number) The size of the disk in MB.
 
 ### Optional
 
-- `bus_number` (Number) The number of the controller itself.
-- `bus_type` (String) The type of disk controller. Possible values: `scsi`, `sata` or `nvme`. Default value is `scsi`.
-- `size_in_mb` (Number) The size of the disk in MB.
-- `storage_profile` (String) Storage profile to override the VM default one. Allowed values are: `silver`, `silver_r1`, `silver_r2`, `gold`, `gold_r1`, `gold_r2`, `gold_hm`, `platinum3k`, `platinum3k_r1`, `platinum3k_r2`, `platinum3k_hm`, `platinum7k`, `platinum7k_r1`, `platinum7k_r2`, `platinum7k_hm`.
-- `unit_number` (Number) The device number on the controller of the disk.
-- `vapp_id` (String) (ForceNew) ID of the vApp. Required if `vapp_name` is not set.
-- `vapp_name` (String) (ForceNew) Name of the vApp. Required if `vapp_id` is not set.
+- `bus_number` (Number) The bus number of the disk controller. If the disk is attached to a VM and this attribute is not set, the disk will be attached to the first available bus. Value must be between 0 and 3.
+- `bus_type` (String) The type of disk controller. Value must be one of : `IDE`, `SATA`, `SCSI`, `NVME`. Value defaults to `SCSI`.
+- `is_detachable` (Boolean) (ForceNew) If set to true, the disk could be detached from the VM. If set to false, the disk canot detached to the VM. Value defaults to `false`.
+- `name` (String) The name of the disk. If is_detachable attribute is set and the value is one of `true`, this attribute is REQUIRED.
+- `storage_profile` (String) The name of the storage profile. If not set, the default storage profile will be used. Value must be one of : `silver`, `silver_r1`, `silver_r2`, `gold`, `gold_r1`, `gold_r2`, `gold_hm`, `platinum3k`, `platinum3k_r1`, `platinum3k_r2`, `platinum3k_hm`, `platinum7k`, `platinum7k_r1`, `platinum7k_r2`, `platinum7k_hm`.
+- `unit_number` (Number) The unit number of the disk controller. If the disk is attached to a VM and this attribute is not set, the disk will be attached to the first available unit. Value must be between 0 and 15.
+- `vapp_id` (String) (ForceNew) ID of the vApp. Ensure that one and only one attribute from this collection is set : `vapp_name`, `vapp_id`.
+- `vapp_name` (String) (ForceNew) Name of the vApp. Ensure that one and only one attribute from this collection is set : `vapp_id`, `vapp_name`.
 - `vdc` (String) (ForceNew) The name of vDC to use, optional if defined at provider level.
-- `vm_id` (String) The ID of the VM. If `vm_name` is not set and `ìs_detachable` is set to `true`, the disk will be attached to any VM. This field is required if `is_detachable` is set to `false`.
-- `vm_name` (String) The name of the VM. If `vm_id` is not set and `ìs_detachable` is set to `true`, the disk will be attached to any VM. This field is required if `is_detachable` is set to `false`.
+- `vm_id` (String) The ID of the VM where the disk will be attached. Value must satisfy at least one of the validations: If is_detachable attribute is set and the value is one of false, this attribute is REQUIRED + Ensure that one and only one attribute from this collection is set: "[vm_name]".
+- `vm_name` (String) The name of the VM where the disk will be attached. Value must satisfy at least one of the validations: If is_detachable attribute is set and the value is one of false, this attribute is REQUIRED + Ensure that one and only one attribute from this collection is set: "[vm_id]".
 
 ### Read-Only
 
-- `id` (String) The ID of the disk.
+- `id` (String) The ID of the VM.
 
 ## Import
 

go.mod

@@ -5,7 +5,7 @@ go 1.20
 require (
 	github.com/FrangipaneTeam/terraform-plugin-framework-planmodifiers v1.2.2
 	github.com/FrangipaneTeam/terraform-plugin-framework-superschema v1.3.0
-	github.com/FrangipaneTeam/terraform-plugin-framework-validators v1.5.1
+	github.com/FrangipaneTeam/terraform-plugin-framework-validators v1.6.3
 	github.com/antihax/optional v1.0.0
 	github.com/google/uuid v1.3.0
 	github.com/hashicorp/terraform-plugin-docs v0.15.0