Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add resource/datasource cloudavenue_edgegateway_dhcp_binding #429

Merged
merged 6 commits into from
Jul 26, 2023
Merged

feat: add resource/datasource cloudavenue_edgegateway_dhcp_binding #429

merged 6 commits into from
Jul 26, 2023

Conversation

azrod
Copy link
Member

@azrod azrod commented Jul 25, 2023 •
edited
Loading

Description of your changes

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

=== RUN   TestAccDhcpForwardingDataSource
--- PASS: TestAccDhcpForwardingDataSource (95.10s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/tests/edgegw      95.687s

=== RUN   TestAccDhcpForwardingResource
--- PASS: TestAccDhcpForwardingResource (395.57s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/tests/edgegw      396.086s

@azrod azrod linked an issue Jul 25, 2023 that may be closed by this pull request
[New Resource]: Add cloudavenue_edgegateway_dhcp_forwarding #421
Closed
@crown-app crown-app bot added Feature size/L Large PR labels Jul 25, 2023
@crown-app
Copy link

crown-app bot commented Jul 25, 2023

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

@crown-app crown-app bot added Test size/XL Extra large PR and removed size/L Large PR labels Jul 25, 2023
@azrod azrod force-pushed the 421-new-resource-add-cloudavenue_edgegateway_dhcp_forwarding branch 3 times, most recently from 8845db2 to c9c9a19 Compare July 26, 2023 05:53
@azrod azrod linked an issue Jul 26, 2023 that may be closed by this pull request
[New Datasource]: Add cloudavenue_edgegateway_dhcp_forwarding #422
Closed
@azrod azrod marked this pull request as ready for review July 26, 2023 05:56
@azrod azrod requested a review from a team as a code owner July 26, 2023 05:56
@azrod azrod force-pushed the 421-new-resource-add-cloudavenue_edgegateway_dhcp_forwarding branch 3 times, most recently from cc24ef0 to fca3ad8 Compare July 26, 2023 07:58
@azrod azrod force-pushed the 421-new-resource-add-cloudavenue_edgegateway_dhcp_forwarding branch from fca3ad8 to 6581c58 Compare July 26, 2023 08:01
@azrod azrod force-pushed the 421-new-resource-add-cloudavenue_edgegateway_dhcp_forwarding branch from 6581c58 to 6727c3e Compare July 26, 2023 08:02
@dmicheneau dmicheneau merged commit 3f3b7fb into main Jul 26, 2023
@dmicheneau dmicheneau deleted the 421-new-resource-add-cloudavenue_edgegateway_dhcp_forwarding branch July 26, 2023 08:12
gaetanars pushed a commit that referenced this pull request Jul 26, 2023
chore: update CHANGELOG.md for #429
ca7ba96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmicheneau dmicheneau dmicheneau approved these changes

Assignees
No one assigned
Labels
size/XL Extra large PR
Projects
None yet
Milestone
No milestone
2 participants
@azrod @dmicheneau