Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance delete lifecycle with new hooks (pre/post delete) #212

Open
o-orand opened this issue Nov 26, 2018 · 3 comments
Open

Enhance delete lifecycle with new hooks (pre/post delete) #212

o-orand opened this issue Nov 26, 2018 · 3 comments

Comments

@o-orand
Copy link
Member

o-orand commented Nov 26, 2018

Is your feature request related to a problem? Please describe.
When a bosh delete is executed, it may require additional cleanup (uaa, etc...). Currently, COA require each deployment to develop custom cleanup solution.

Describe the solution you'd like
Enhance delete lifecycle with a pre-delete.sh and a post-delete.sh to ease theses additional cleanup step.
It may impact #67

@gberche-orange
Copy link
Member

gberche-orange commented Jan 8, 2019

Limitations of adding shell hooks along with #187 (exposing credhub credentials in shell hooks):

  • security risks: limits isolation among deployments/root-deployments
  • broadens fragile use of the shell hooks: dependent binaries are not versionned

Alternative is to have deployer-specific life cycle events:

@gberche-orange
Copy link
Member

Impacts if not implementing this enhancement: resources leaks

  • backups in S3
  • credhub entries
  • uaa clients for shield (idempotent creation)

Contexts of these leaks:

  • disabled deployment by an operator
  • on-demand service instances deployments deleted by end users

@poblin-orange
Copy link
Member

poblin-orange commented Nov 15, 2019

also note the new bosh lifecycle https://bosh.io/docs/pre-stop/
bosh deployment could leverage this lifecycle (see eg: orange-cloudfoundry/generic-scripting-release#4)

support added in v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants