OHRM5X-782: Installer Send Registration Data #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SandeepaOHRM
commented
Apr 26, 2022
| @@ -35,7 +35,7 @@ class DataRegistrationService | |||
| private function getHttpClient(): Client | |||
| { | |||
| if (!isset($this->apiClient)) { | |||
| $this->apiClient = new Client(['base_uri' => Config::REGISTRATION_BETA_URL]); | |||
There was a problem hiding this comment.
This was my mistake to commit beta url. I removed it.
| @@ -35,7 +35,7 @@ class DataRegistrationService | |||
| private function getHttpClient(): Client | |||
| { | |||
| if (!isset($this->apiClient)) { | |||
| $this->apiClient = new Client(['base_uri' => Config::REGISTRATION_BETA_URL]); | |||
| $this->apiClient = new Client(['base_uri' => Config::REGISTRATION_URL]); | |||
There was a problem hiding this comment.
Removed the beta url
SandeepaOHRM
commented
Apr 26, 2022
| ]; | ||
| } | ||
|
|
||
| protected function sendRegistrationData() |
There was a problem hiding this comment.
add doc comment
There was a problem hiding this comment.
this is outdated. I have fixed it already
| @@ -35,7 +35,7 @@ class DataRegistrationService | |||
| private function getHttpClient(): Client | |||
| { | |||
| if (!isset($this->apiClient)) { | |||
| $this->apiClient = new Client(['base_uri' => Config::REGISTRATION_BETA_URL]); | |||
| $this->apiClient = new Client(['base_uri' => Config::REGISTRATION_URL]); | |||
There was a problem hiding this comment.
refactor the name into httpClient
RajithaKumara
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:-