Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OHRM5X-320: Installer defect fixes #1262

Merged
merged 8 commits into from
Apr 29, 2022
Merged

OHRM5X-320: Installer defect fixes #1262

merged 8 commits into from
Apr 29, 2022

Conversation

Super-Chama
Copy link
Member

@Super-Chama Super-Chama commented Apr 28, 2022 •
edited
Loading

  • OHRM5X-1327: Installer - DB name validations added
  • OHRM5X-1319: Installer - Refactor install process, show error message of failure
  • OHRM5X-1299: Upgrader - current version details dropdown required validation fix
  • OHRM5X-1319: Installer - DB Config screen style fixes, layout style fixes
  • OHRM5X-1323: Installer - Organization name length validation fix
  • OHRM5X-1319: Installer - Licence acceptance remove required text
  • OHRM5X-1317: Installer - Installation steps renamed
  • OHRM5X-1322: Installer - admin user creation email length validation fix

@Super-Chama Super-Chama marked this pull request as ready for review April 28, 2022 20:08
devishke-orange
devishke-orange approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@devishke-orange devishke-orange left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked fixes with a build test. No issues 👍

Had a question with regard to error message on install screen. It says to check installer.log file but seems there is no error message being logged (for scenarios I checked)

@RajithaKumara RajithaKumara merged commit 69ff0b8 into orangehrm:5.0 Apr 29, 2022
@Super-Chama Super-Chama deleted the installer_fixes branch April 29, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devishke-orange devishke-orange devishke-orange approved these changes

@RajithaKumara RajithaKumara RajithaKumara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Super-Chama @RajithaKumara @devishke-orange