This repository has been archived by the owner on Apr 7, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: remove dependency of
docker-credentials-helper
and support context #68feat: remove dependency of
docker-credentials-helper
and support context #68Changes from 13 commits
60a145c
0c407a7
fe49d73
eea06fa
46b532c
0078759
d0639f3
8c2d0b8
56af570
93bc037
91e9ec3
f0af3dd
6cea0ef
147aedf
5f48d1c
6592b51
94da9e1
714e967
da11fc1
4756dcc
e55f920
691b18c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to be used as
executer.New()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question: Do weed need to check if the executable can be found? Like using
exec.LookPath
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need more discussion on that? This is worth a future "feat" PR. I'll leave it as it is for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a good idea and is necessary for detecting
desktop.exe
. However, we can leave it in the next PR.