This repository has been archived by the owner on Apr 7, 2024. It is now read-only.
fix: added back handling no credentials error #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
wangxiaoxuan273
requested review from
shizhMSFT,
Wwwsylvia and
TerryHowe
as code owners
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 82.27% 82.41% +0.13%
==========================================
Files 6 6
Lines 378 381 +3
==========================================
+ Hits 311 314 +3
Misses 45 45
Partials 22 22
|
shizhMSFT
reviewed
Jun 8, 2023
| @@ -67,6 +68,9 @@ func (ns *nativeStore) Get(ctx context.Context, serverAddress string) (auth.Cred | |||
| var cred auth.Credential | |||
| out, err := ns.exec.Execute(ctx, strings.NewReader(serverAddress), "get") | |||
| if err != nil { | |||
| if err.Error() == errCredentialsNotFoundMessage { | |||
There was a problem hiding this comment.
Can you add back the original comment?
There was a problem hiding this comment.
Added back the comment
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the error of PR #68