Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

design: Tag() and TagN() should return a descriptor #395

Closed
shizhMSFT opened this issue Jan 3, 2023 · 0 comments · Fixed by #396
Closed

design: Tag() and TagN() should return a descriptor #395

shizhMSFT opened this issue Jan 3, 2023 · 0 comments · Fixed by #396
Assignees
@shizhMSFT
Labels
bug Something isn't working
Milestone
v2.0.0

Comments

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Jan 3, 2023 •
edited
Loading

oras.Tag() and oras.TagN() do not return a descriptor. Thus, there is no way to know which content is re-tagged exactly.

This is a design flaw / bug and should be fixed.
@shizhMSFT shizhMSFT added the bug Something isn't working label Jan 3, 2023
@shizhMSFT shizhMSFT added this to the v2.0.0 milestone Jan 3, 2023
@shizhMSFT shizhMSFT self-assigned this Jan 3, 2023
@shizhMSFT shizhMSFT changed the title design: Tag and TagN should return a descriptor design: Tag() and TagN() should return a descriptor Jan 3, 2023
@shizhMSFT shizhMSFT mentioned this issue Jan 3, 2023
Merged
shizhMSFT added a commit that referenced this issue Jan 6, 2023
@shizhMSFT
fix!: Tag() and TagN() return a descriptor (#396)
31299c3 
Fix #395

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shizhMSFT shizhMSFT

Labels
bug Something isn't working
Projects
No open projects
ORAS-Planning
Status: Done
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

fix!: Tag() and TagN() return a descriptor shizhMSFT/oras-go
1 participant
@shizhMSFT