-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: auth.StaticCredential
does not properly handle docker.io
#484
Labels
bug
Something isn't working
Comments
One of the workarounds before this bug gets fixed is that, passing repo, _ := remote.NewRepository("docker.io/library/hello-world")
repo.Client := &auth.Client{
// other fields...
Credential: auth.StaticCredential(repo.Reference.Host(), cred),
} |
Wwwsylvia
changed the title
Bug:
Bug: Apr 18, 2023
auth.Credential
does not properly handle docker.io
auth.StaticCredential
does not properly handle docker.io
Sorry I don't get the workaround. Suppose the registry name is docker.io, shouldn't |
|
Wwwsylvia
added a commit
that referenced
this issue
May 10, 2023
Fixes #484 Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When
remote.Registry
is accessingdocker.io
, it actually issues requests toregistry-1.docker.io
. Therefore, it expects theclient.Credential
to return the credential forregistry-1.docker.io
instead ofdocker.io
.But the current implementation of
auth.StaticCredential
does not handle this case.The text was updated successfully, but these errors were encountered: