Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the number of auth requests #594

Closed
Wwwsylvia opened this issue Sep 12, 2023 · 0 comments · Fixed by #618
Closed

Optimize the number of auth requests #594

Wwwsylvia opened this issue Sep 12, 2023 · 0 comments · Fixed by #618
Labels
perf Performance related issues
Milestone

Comments

@Wwwsylvia
Copy link
Member

Wwwsylvia commented Sep 12, 2023

We had an issue on ORAS for optimizing the number of auth request: oras-project/oras#1097
We should also review oras-go and apply similar optimization. For instance, we can add pull scope hint in addition to delete in the referrers tag schema code path on manifest delete:

manifestJSON, err := content.FetchAll(ctx, s, target)
if err != nil {
return err
}
if err := s.indexReferrersForDelete(ctx, target, manifestJSON); err != nil {
return err
}
}
return s.repo.delete(ctx, target, true)

@Wwwsylvia Wwwsylvia added the perf Performance related issues label Sep 12, 2023
@yizha1 yizha1 added this to the v2.4.0 milestone Sep 12, 2023
Wwwsylvia added a commit that referenced this issue Oct 18, 2023
Add `pull` and `delete` scope hints before attempting client-side indexing on manifest delete.

Resolve: #594 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Wwwsylvia added a commit to Wwwsylvia/oras-go that referenced this issue Oct 20, 2023
Add `pull` and `delete` scope hints before attempting client-side indexing on manifest delete.

Resolve: oras-project#594 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf Performance related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants