Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update v1 to v2 migration guide #735

Closed
shizhMSFT opened this issue Mar 26, 2024 · 0 comments · Fixed by #752
Closed

Update v1 to v2 migration guide #735

shizhMSFT opened this issue Mar 26, 2024 · 0 comments · Fixed by #752
Assignees
@Wwwsylvia
Labels
documentation Improvements or additions to documentation v1 Things belongs to version 1.x v2 Things belongs to version 2.x
Milestone
v2.6.0

Comments

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Mar 26, 2024 •
edited
Loading

The MIGRATION_GUIDE.md is outdated and does not reflect oras-go v2.5.0.

For example,

oras-go/MIGRATION_GUIDE.md

Line 20 in 9b6f321

- No longer supports `docker.Login` and `docker.Logout` (removes the dependency on `docker`); instead, provides authentication through [auth.Client](https://pkg.go.dev/oras.land/oras-go/v2/registry/remote/auth#Client)

does not hold any longer since we have the credentials pacakge.
@shizhMSFT shizhMSFT added documentation Improvements or additions to documentation v1 Things belongs to version 1.x v2 Things belongs to version 2.x labels Mar 26, 2024
@shizhMSFT shizhMSFT added this to the v2.6.0 milestone Mar 26, 2024
@Wwwsylvia Wwwsylvia mentioned this issue Apr 29, 2024
Merged
Wwwsylvia added a commit that referenced this issue Apr 30, 2024
@Wwwsylvia
docs: update migration guide and copy doc (#752)
6fce64e 
1. Update MIGRATION_GUIDE.md
2. Revise the go doc comments for Copy and Extended Copy to make it
easier to understand

Resolve: #735
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wwwsylvia Wwwsylvia

Labels
documentation Improvements or additions to documentation v1 Things belongs to version 1.x v2 Things belongs to version 2.x
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

docs: update migration guide and copy doc Wwwsylvia/oras-go
2 participants
@Wwwsylvia @shizhMSFT