-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: add read-only interfaces #283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Wwwsylvia
changed the title
refactor: Add Immutable interfaces
refactor: add Immutable interfaces
Aug 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #283 +/- ##
=======================================
Coverage 70.77% 70.77%
=======================================
Files 36 36
Lines 3357 3357
=======================================
Hits 2376 2376
Misses 734 734
Partials 247 247
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wwwsylvia
changed the title
refactor: add Immutable interfaces
refactor!: add read-only interfaces
Aug 29, 2022
shizhMSFT
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add read-only interfaces to support #282
Part of #272
BREAKING CHANGE:
src
fororas.CopyGraph
functionsrc
fororas.Copy
functionsrc
fororas.CopyOptions.MapRoot
src
fororas.ExtendedCopyGraph
functionsrc
fororas.ExtendedCopy
functionsrc
fororas.ExtendedCopyGraphOptions.FindPredecessors
target
fororas.Resolve
functionSigned-off-by: Sylvia Lei lixlei@microsoft.com