Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: add read-only interfaces #283

Merged
merged 7 commits into from
Aug 29, 2022
Merged

Conversation

Wwwsylvia
Copy link
Member

@Wwwsylvia Wwwsylvia commented Aug 26, 2022

Add read-only interfaces to support #282

Part of #272
BREAKING CHANGE:

  • Change the parameter type of src for oras.CopyGraph function
  • Change the parameter type of src for oras.Copy function
  • Change the parameter type of src for oras.CopyOptions.MapRoot
  • Change the parameter type of src for oras.ExtendedCopyGraph function
  • Change the parameter type of src for oras.ExtendedCopy function
  • Change the parameter type of src for oras.ExtendedCopyGraphOptions.FindPredecessors
  • Change the parameter type of target for oras.Resolve function

Signed-off-by: Sylvia Lei lixlei@microsoft.com

Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia requested a review from shizhMSFT August 26, 2022 08:39
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia changed the title refactor: Add Immutable interfaces refactor: add Immutable interfaces Aug 26, 2022
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #283 (ac89ad4) into main (98e72a2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   70.77%   70.77%           
=======================================
  Files          36       36           
  Lines        3357     3357           
=======================================
  Hits         2376     2376           
  Misses        734      734           
  Partials      247      247           
Impacted Files Coverage Δ
content/graph.go 0.00% <ø> (ø)
content/storage.go 0.00% <ø> (ø)
internal/registryutil/proxy.go 71.42% <ø> (ø)
content.go 56.25% <100.00%> (ø)
copy.go 60.78% <100.00%> (ø)
extendedcopy.go 68.42% <100.00%> (ø)
internal/cas/proxy.go 78.94% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Wwwsylvia Wwwsylvia changed the title refactor: add Immutable interfaces refactor!: add read-only interfaces Aug 29, 2022
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@shizhMSFT shizhMSFT merged commit 2946dfc into oras-project:main Aug 29, 2022
@Wwwsylvia Wwwsylvia deleted the immutable branch August 30, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants