-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change foreign layer error message at repository.Fetch() #377
Conversation
Codecov Report
@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 72.24% 73.84% +1.59%
==========================================
Files 42 45 +3
Lines 4093 4339 +246
==========================================
+ Hits 2957 3204 +247
+ Misses 855 844 -11
- Partials 281 291 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Some repositories may contain foreign layers which pointing to the repository itself, e.g.
So it's better to return unsupported only when a layer is foreign and not found. Same logic should apply to OCI target. |
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #319
Current result with oras-cli:
Signed-off-by: wangxiaoxuan273 wangxiaoxuan119@gmail.com