Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reading OCI layout from tarballs #379

Merged
merged 12 commits into from
Dec 8, 2022

Conversation

Wwwsylvia
Copy link
Member

  1. Support oci.NewStorageFromTar
  2. Support oci.NewFromTar

Resolves: #373

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Merging #379 (94cdecd) into main (04d11f9) will decrease coverage by 0.10%.
The diff coverage is 67.03%.

@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   72.02%   71.92%   -0.11%     
==========================================
  Files          45       46       +1     
  Lines        4172     4263      +91     
==========================================
+ Hits         3005     3066      +61     
- Misses        878      899      +21     
- Partials      289      298       +9     
Impacted Files Coverage Δ
content/oci/readonlyoci.go 64.70% <50.00%> (-1.43%) ⬇️
content/oci/readonlystorage.go 87.17% <50.00%> (-6.76%) ⬇️
internal/fs/tarfs/tarfs.go 69.62% <69.62%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 0382be2 into oras-project:main Dec 8, 2022
@Wwwsylvia Wwwsylvia deleted the oci_tarfs branch December 8, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support reading OCI layout from tarballs
3 participants