Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor OCI store to fully support Predecessors() and Resolve() #385

Merged
merged 12 commits into from
Dec 12, 2022
Merged

refactor: refactor OCI store to fully support Predecessors() and Resolve() #385

merged 12 commits into from
Dec 12, 2022

Conversation

Wwwsylvia
Copy link
Member

@Wwwsylvia Wwwsylvia commented Dec 12, 2022 •
edited
Loading

  1. Support discovering predecessors that are not tagged
  2. Support resolving a manifest by its digest
  3. Support resolving a blob by its digest

Resolves: #342

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022 •
edited
Loading

Codecov Report

Merging #385 (ff7564a) into main (79e13bc) will increase coverage by 0.32%.
The diff coverage is 72.22%.

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   72.00%   72.32%   +0.32%     
==========================================
  Files          46       46              
  Lines        4275     4318      +43     
==========================================
+ Hits         3078     3123      +45     
+ Misses        899      898       -1     
+ Partials      298      297       -1
Impacted Files Coverage Δ
content/oci/readonlyoci.go 65.65% <65.78%> (+0.95%) ⬆️
content/oci/oci.go 69.93% <77.41%> (+4.28%) ⬆️
content/descriptor.go 100.00% <100.00%> (ø)
content/oci/readonlystorage.go 87.50% <100.00%> (+0.32%) ⬆️
copy.go 62.55% <0.00%> (-0.16%) ⬇️
internal/syncutil/merge.go 87.50% <0.00%> (+17.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Wwwsylvia Wwwsylvia changed the title refactor: refactor OCI store to fully support Predecessors() and Resolve()` refactor: refactor OCI store to fully support Predecessors() and Resolve() Dec 12, 2022
shizhMSFT
shizhMSFT reviewed Dec 12, 2022
View reviewed changes
content/oci/readonlyoci.go Show resolved Hide resolved
content/oci/readonlyoci.go Outdated Show resolved Hide resolved
content/oci/oci.go Outdated Show resolved Hide resolved
content/oci/readonlyoci.go Outdated Show resolved Hide resolved
content/oci/readonlyoci.go Show resolved Hide resolved
@Wwwsylvia Wwwsylvia marked this pull request as ready for review December 12, 2022 11:49
shizhMSFT
shizhMSFT approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia
extract common functions
dd43e80 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
processIndex + unit tests
33514f3 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
modify unit test
77a9dfd 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
refactor tests
347826e 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
resolve blob by digest
f467537 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
lock index
65a8b30 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
rename
70da41c 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
fix
7ae933b 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
test resolve blob
75e5e4e 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
test comments
33b352f 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
address comments
50299d6 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
refactor tag()
2c0726b 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 4e58192 into oras-project:main Dec 12, 2022
@Wwwsylvia Wwwsylvia deleted the oci_index branch December 12, 2022 12:46
@eiffel-fl eiffel-fl mentioned this pull request Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OCI store should support discovering predecessors that are not tagged
3 participants
@Wwwsylvia @codecov-commenter @shizhMSFT