Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: fix error when extracting folder containing symbolic links #411

Merged
merged 10 commits into from
Jan 16, 2023

Conversation

Wwwsylvia
Copy link
Member

@Wwwsylvia Wwwsylvia commented Jan 16, 2023

Fixes part of #404
Fixes: #402
BREAKING CHANGE: file.New() and other constructors now return an error

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia requested a review from shizhMSFT January 16, 2023 11:04
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Merging #411 (4793d40) into main (1484139) will increase coverage by 0.33%.
The diff coverage is 77.27%.

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   72.31%   72.65%   +0.33%     
==========================================
  Files          46       46              
  Lines        4349     4359      +10     
==========================================
+ Hits         3145     3167      +22     
+ Misses        903      893      -10     
+ Partials      301      299       -2     
Impacted Files Coverage Δ
content/file/file.go 75.32% <60.00%> (+0.25%) ⬆️
content/file/utils.go 66.85% <91.66%> (+8.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 9867c6a into oras-project:main Jan 16, 2023
@Wwwsylvia Wwwsylvia deleted the symlink branch January 17, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: file store fails to extract folder containing symbolic links
3 participants