Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: use absolute path for OCI root #412

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Conversation

Wwwsylvia
Copy link
Member

@Wwwsylvia Wwwsylvia commented Jan 16, 2023

Fixes: #404
BREAKING CHANGE: oci.NewStorage() now returns an error

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Merging #412 (24898a5) into main (aa4bd09) will increase coverage by 0.08%.
The diff coverage is 64.58%.

@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   72.39%   72.48%   +0.08%     
==========================================
  Files          46       46              
  Lines        4361     4375      +14     
==========================================
+ Hits         3157     3171      +14     
+ Misses        903      901       -2     
- Partials      301      303       +2     
Impacted Files Coverage Δ
internal/fs/tarfs/tarfs.go 67.46% <40.00%> (-2.16%) ⬇️
content/oci/oci.go 68.78% <41.66%> (-2.36%) ⬇️
content/file/file.go 75.32% <60.00%> (-0.51%) ⬇️
content/oci/storage.go 61.64% <77.77%> (-2.13%) ⬇️
content/file/utils.go 66.85% <91.66%> (+8.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia merged commit 05595eb into oras-project:main Jan 17, 2023
@Wwwsylvia Wwwsylvia deleted the oci_root branch January 17, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: OCI store and File store should record an absolute path instead of a relative path for root
3 participants