-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registry/remote): implement Mount
#500
Conversation
Mount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you sign-off your commit to pass the DCO check?
Pinging @Wwwsylvia who I think has a lot of history with mount :). Correct me if I'm wrong Sylvia. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pinging @Wwwsylvia for reviewing this PR. |
@sajayantony You still remember my history with mount😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds support for "mounting" (a.k.a. copy by reference) a blob from one repository to another in the same registry. As documented in https://docs.docker.com/registry/spec/api/#blob and https://github.com/opencontainers/distribution-spec/blob/main/spec.md#mounting-a-blob-from-another-repository. I've also manually verified that this works against at least one real registry implementation (zot). Fixes oras-project#337 This implements blob-mount functionality as described Signed-off-by: Roger Peppe <rogpeppe@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds support for "mounting" (a.k.a. copy by reference) a blob from one repository to another in the same registry.
As documented in https://docs.docker.com/registry/spec/api/#blob and https://github.com/opencontainers/distribution-spec/blob/main/spec.md#mounting-a-blob-from-another-repository.
I've also manually verified that this works against at least one real registry implementation (zot).
Fixes #337
This implements blob-mount functionality as described