Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: increase code coverage threshold to 75% #666

Merged
merged 2 commits into from
Jan 3, 2024
Merged

build: increase code coverage threshold to 75% #666

merged 2 commits into from
Jan 3, 2024

Conversation

wangxiaoxuan273
Copy link
Contributor

Resolves #662

@wangxiaoxuan273
fix: increase coverage to 75%
47a4021 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jan 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48f0943) 75.46% compared to head (44dcd52) 75.46%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #666   +/-   ##
=======================================
  Coverage   75.46%   75.46%           
=======================================
  Files          59       59           
  Lines        5640     5640           
=======================================
  Hits         4256     4256           
  Misses       1019     1019           
  Partials      365      365

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangxiaoxuan273 wangxiaoxuan273 changed the title fix: increase coverage to 75% fix: increase code threshold coverage to 75% Jan 3, 2024
@wangxiaoxuan273 wangxiaoxuan273 changed the title fix: increase code threshold coverage to 75% fix: increase code coverage threshold to 75% Jan 3, 2024
shizhMSFT
shizhMSFT approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Wwwsylvia
Wwwsylvia reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if the PR title should start with build?

.github/.codecov.yml Show resolved Hide resolved
@wangxiaoxuan273 wangxiaoxuan273 changed the title fix: increase code coverage threshold to 75% build: increase code coverage threshold to 75% Jan 3, 2024
@wangxiaoxuan273
empty line
44dcd52 
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Wwwsylvia
Wwwsylvia approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 0b78aa6 into oras-project:main Jan 3, 2024
9 checks passed
@wangxiaoxuan273 wangxiaoxuan273 deleted the coverage branch January 4, 2024 06:01
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase code coverage threshold to 75%
3 participants
@wangxiaoxuan273 @Wwwsylvia @shizhMSFT